Skip to content
This repository has been archived by the owner on Jun 29, 2023. It is now read-only.

Allow disputing Create2Transfer with nonexistent receiver #670

Conversation

b-tarczynski
Copy link
Contributor

Resolves #669

@github-actions github-actions bot added the contracts This PR changes some contracts label Oct 19, 2021
@jacque006
Copy link
Collaborator

This looks fine to me, similar to work in #655 but much more explicit for zero/empty case.

@ChihChengLiang can you take a look as well?

@b-tarczynski it would be good to have test case for this as well, likely can be added in https://github.com/thehubbleproject/hubble-contracts/blob/master/test/slow/rollup.create2Transfer.test.ts

Copy link
Collaborator

@ChihChengLiang ChihChengLiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch of this bug!

contracts/libs/Authenticity.sol Outdated Show resolved Hide resolved
@b-tarczynski
Copy link
Contributor Author

This looks fine to me, similar to work in #655 but much more explicit for zero/empty case.

@ChihChengLiang can you take a look as well?

@b-tarczynski it would be good to have test case for this as well, likely can be added in https://github.com/thehubbleproject/hubble-contracts/blob/master/test/slow/rollup.create2Transfer.test.ts

I added test for these changes as you suggested

@jacque006
Copy link
Collaborator

Docker CI failure can be ignored, unrelated to this work.

@jacque006 jacque006 merged commit 2258195 into thehubbleproject:master Nov 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
contracts This PR changes some contracts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

C2T to non-existent PublicKey
3 participants